Question

Basically I’m trying to add an OnClickListener to a Button in a Dialog, however by simply adding the listener, the app becomes unstable and crashes, and when I try and catch it, the message returned is null. Thanks for taking a look at my problem.

Also, if it helps, this is being triggered when a menu button is pressed.

Creating the dialog:

try {
        final Dialog dialog = new Dialog(List.this);
        dialog.setContentView(R.layout.adddialog);
        dialog.setTitle("Add to the list");
        dialog.setCancelable(true);

        final EditText et = (EditText) findViewById(R.id.itemAddDialog);
        Button ok = (Button) findViewById(R.id.okAddDialog);
        Button cancel = (Button) findViewById(R.id.cancelAddDialog);

        ok.setOnClickListener(new OnClickListener(){
            @Override
            public void onClick(View arg0) {
                //Contents of this function don't matter, It freezes simply by being created
            }
        });

        dialog.show();
        }
catch (Exception e) {
    Toast.makeText(List.this, e.getMessage(), Toast.LENGTH_LONG).show();
}

(Slightly trimmed) XML file:

<LinearLayout
    android:id="@+id/btnpaneAddDialog"
    android:orientation="horizontal"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:gravity="center_horizontal" >

    <Button
        android:id="@+id/okAddDialog"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Add it" />

    <Button
        android:id="@+id/cancelAddDialog"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Cancel" />


</LinearLayout>

Answer 1

Change:

Button ok = (Button) findViewById(R.id.okAddDialog);

to

Button ok = (Button) dialog.findViewById(R.id.okAddDialog);