Question

Can I attach an event to an SqlCommand.Disposed event that will dispose of the SqlCommand’s connection? Here is the code I am testing:

    public static SqlCommand GetCommand(string query, SqlParameter[] paramCollection, bool isStoredProcedure)
    {
        return new DBSettings().CreateCommand(query, paramCollection, isStoredProcedure);
    }

    public SqlCommand CreateCommand(string query, SqlParameter[] paramCollection, bool isStoredProcedure)
    {
        SqlConnection conn = new SqlConnection(connString);
        conn.Open();
        SqlCommand cmd = new SqlCommand(query, conn);
        if (paramCollection.Length > 0)
            cmd.Parameters.AddRange(paramCollection);
        if (isStoredProcedure)
            cmd.CommandType = CommandType.StoredProcedure;
        cmd.Disposed += new EventHandler(cmd_Disposed);
        return cmd;
    }

    protected void cmd_Disposed(object sender, EventArgs e)
    {
        SqlCommand cmd = (SqlCommand)sender;
        cmd.Connection.Dispose();
    }

I want to be able to call the static method GetCommand in a using block and when it is done, dispose of the connection like this:

        using (SqlCommand cmd = GetCommand(query, paramCollection, false))
        {
            //code to execute
        }

Answer 1

Your method should work, but it is really counter-intuitive and I would recommend to rethink the design. Dependant object (command) controlling lifetime of the object it depends on (connection)? What if you want to run more commands on the same connection? What about transactions?