Home/ Questions/Q 6061023
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-23T08:53:29+00:00

For some reason my insert/update check only ever inserts. the value userID does have

  • 0

For some reason my insert/update check only ever inserts. the value userID does have a value so i dont know what is up with this. Any ideas? 

$result = mysql_query("SELECT * FROM users where userID = $userID ");
if (mysql_num_rows($result) > 0) {
   mysql_query("UPDATE users SET firstName='$firstName', lastName='$lastName', 
             birthday='$birthday', update='$today', accessToken='$accessToken', emailOne='$emailOne' WHERE userID='$userId'");
} else {
   mysql_query("INSERT INTO users (userID, firstName, lastName, birthday, updated, accessToken, emailOne ) 
               VALUES ('$userId', '$firstName', '$lastName','$birthday', '$today', '$accessToken', '$emailOne')");
}
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    You’d be far better off doing INSERT ... ON DUPLICATE KEY UPDATE. Your version is subject to race conditions. It’s entirely possible that between the time you do the SELECT * and then attempt the update/insert queries, ANOTHER script has already inserted the same ID number and then your script breaks. This also reduces the database load by one query.

    As well, unless you’ve passed all those variables in the query through mysql_real_escape_string(), you’ll probably be getting a visit from Little Bobby Tables.

    • 0