Question

Hello All, am just a beginner in C# in VS2010 and the reason am learning it is to be able to evolve in game programming, I got the source code of this program and added many things to it. This is the console application source.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace First_Game

{
     class Program
    {
        void DisplayChoices(int heroHitPoints, int monsterHitPoints) // 1st method to display the choices 
        {
            Console.Write(@"
************************************************
Your hero has {0}hp and the Monster has {1}hp
************************************************", heroHitPoints, monsterHitPoints);

            Console.Write(@"
__________________________
Please Choose an action:
(A)ttack
(D)efend
(H)eal
(F)lee
__________________________");
            Console.WriteLine();
        }
        int GetHeroDamage(Random rand)// 2nd Method to calculate the hero's Damage during battle.
     {
         int attackdamage;
         attackdamage = rand.Next(350, 450);
         return attackdamage;
     }
        int GetMonsterDamage(Random rand) // 3rd Method to calculate the monster's damage during the battle.
         {
         int attackdamage;
         attackdamage = rand.Next(250, 350);
         return attackdamage;
     }
        static void Main(string[] args)
        {
            Program CH = new Program();
            int heroHitPoints, monsterHitPoints, attackdamage, healing, fleechance, hitchance;
            Random rand;
            string battlechoice;
            Console.WriteLine("You are facing a Monster!");
            //this is outside the loop so that it will only print once
            heroHitPoints = 1500;// our variables are assigned ouside
            monsterHitPoints =2000;//so that each loop won't "heal" them
            do
            {
                rand = new Random();
                CH.DisplayChoices(heroHitPoints, monsterHitPoints);
                battlechoice = Console.ReadLine();
                switch (battlechoice)
                {
                    case "a":
                    case "A"://this way a or A work
                        hitchance = rand.Next(0, 100);
                        if (hitchance > 30)
                        {
                            attackdamage = CH.GetHeroDamage(rand);
                            Console.WriteLine("The hero attacks!");
                            monsterHitPoints -= attackdamage;
                            Console.WriteLine("The monster loses {0}hp", attackdamage);
                        }
                        else
                        {
                            Console.WriteLine("You missed!");
                        }
                        break;
                    case "d":
                    case "D":
                        Console.WriteLine("The Hero Defends");
                        break;
                    case "h":
                    case "H":
                        healing = 400;
                        heroHitPoints += healing;
                        Console.WriteLine("The Hero uses a Potion!");
                        Console.WriteLine("The Hero heals himself for {0} Points", healing);
                        break;
                    case "f":
                    case "F":
                        fleechance = rand.Next(0, 100);
                        if (fleechance > 40)
                        {
                            Console.WriteLine("The hero fled!");
                            Console.ReadLine();
                            Environment.Exit(0);
                        }
                        else
                        {
                            Console.WriteLine("Fleeing Failed");
                            Console.ReadLine();

                        }
                        break;
                    default://defaults always a good idea with user input
                        Console.WriteLine("Sorry that choice was invalid and the monster took a cheap shot!");
                        break;
                }

                Console.WriteLine();
                if (monsterHitPoints > 0)//if the monster is still alive
                {
                    hitchance = rand.Next(0, 100);
                    if (hitchance > 30)
                    {
                        attackdamage = CH.GetMonsterDamage(rand);
                        Console.WriteLine("The Monster Attacks!");
                        if (battlechoice == "d" || battlechoice == "D")
                        { //this is so that defend has some sort of benefit
                            attackdamage /= 2;
                        }
                        heroHitPoints -= attackdamage;//subtract the damage
                        Console.WriteLine("The Hero loses {0}hp", attackdamage);
                    }
                    Console.WriteLine("Press Enter to Continue");
                    Console.ReadLine();
                    Console.Clear();//this clears the screen so that we don't have the
                    //last turns info on it.
                }
            }
            while (heroHitPoints > 0 && monsterHitPoints > 0);

            if (heroHitPoints > 0)
            {
                Console.WriteLine("You are Victorious!");
            }
            else
            {
                Console.WriteLine("You have been defeated :(");
            }
            Console.ReadLine();
        }
    }

     }

The program is supposed to ask you to pick a choice, and after you do it performs it, the monster is supposed to attack no matter what. I created 3 methods and called them.
My problem is that the part that starts with an IF statement and ends before the while sometimes runs and sometimes doesn’t, like it’s completely random, I thought it would be something to do with the monster’s hitchance but that wasn’t the case, help is appreciated. VS2010 does not give me any errors, and the hero attacks every time even though am using the same way with both of them.

Answer 1

OK. I’ve tried it and it works ok, but you don’t print anything when the monster misses, is this what you mean by random failure? To rectify it, simply append an else to the condition:

hitchance = rand.Next(0, 100);
if (hitchance > 30)
{
    attackdamage = CH.GetMonsterDamage(rand);
    Console.WriteLine("The Monster Attacks!");
    if (battlechoice == "d" || battlechoice == "D")
    { //this is so that defend has some sort of benefit
        attackdamage /= 2;
    }
    heroHitPoints -= attackdamage;//subtract the damage
    Console.WriteLine("The Hero loses {0}hp", attackdamage);
}
else
{
    Console.WriteLine("The monster misses!");
}