Question

I am just wondering if I’m doign something that might be bad, although it seems a very practical solution to me…

I have two forms which the user will have to walk through. The user clicks on a button and form1 pops up. The user presses OK and the second one pops up. The user click OK again and the screens are gone. Or the user clicks on Retry and the screen goes back to the first one. The two screens are completely different sizes with different information.

So I came up with this code:

  Form1 := TForm1.Create(SharedData);
  Form2 := TForm2.Create(SharedData);
  repeat
    ModalResult := Form1.ShowModal;
    if (ModalResult = mrOK) then ModalResult := Form2.ShowModal;
  until (ModalResult <> mrRetry);
  Form1.Release;
  Form2.Release;

I’ve tested this code and it seems to work like a charm. In this code, SharedData is an object that contains data that’s manipulated by both forms. I create this object before the two forms are created and when ModalResult==mrOK I just write the data back to the database.

Problem is, while I think this is a clean solution to handle flipping between two forms, I can’t remember ever seeing something like this construction before. Of course, I’m a Genius. (At least, me Ego tells me I am.) But would there be something against using this piece of code or is it just fine?

Answer 1

If the code does what it’s supposed to, I think it’s fine. I’ve not seen anything quite like it before either, but it’s pretty obvious what it’s doing… which in my book is far better than just blindly following other people’s work. 🙂