Question

I am new to php and trying to make dropdown list work with wordpress user table

I am trying to set user id as a value and want to display user_login but not able to get properly. It is rendering two time with wrong id. Here is my code

global $wpdb;
        $userids = $wpdb->get_col("SELECT ID FROM $wpdb->users");
        $user_logins = $wpdb->get_col("SELECT user_login FROM $wpdb->users");

        echo '<select>';
        foreach($userids as $userid){
            foreach($user_logins as $user_login)
            echo '<option value="'.$userid.'" selected="'.$user_login.'">'.$user_login.'</option>';
        }
        echo '</select>';

Thanks a lot

Answer 1

If you need to use the two-queries that you’re currently using, you can iterate with a counter instead of foreach:

$count = count($userids);
for ($i = 0; $i < $count; $i++) {
    echo '<option value="' . $userids[$i] . '" selected="' . $user_logins[$i] . '">' . $user_logins[$i] . '</option>';
}

You can combine the two queries into a single query using WordPress’s get_results() method:

$users = $wpdb->get_results("SELECT ID, user_login FROM $wpdb->users");
echo '<select>';
foreach ($users as $user) {
    echo '<option value="' . $user->ID . '" selected="' . $user->user_login . '">' . $user->user_login . '</option>';
}
echo '</select>';

It’s also worth pointing out, the option‘s selected attribute is being improperly used. It should only be set on a single option, and is generally set with a value of “selected”, such as selected="selected". Refer to the W3C documentation for more info regarding that though.