Question

I have a problem with the following code :

 class Program
{
    public static void Progress(ProgressEventArgs e)
    {
        int result = e.getPartialResult;
        int stack_value = e.getValue ;
        double max = System.Convert.ToDouble(numbers[j]);
        System.Convert.ToDouble(stack_value);
        double percent = (stack_value / max) * 100;

        Console.CursorLeft = 18;
        Console.Write(result + " ");
        Console.CursorLeft = 46;
        Console.Write(System.Convert.ToInt32(percent) + "%      ");

    }
    public static void Calculate(int number, int time=0)
    {

        Factorial Fact = new Factorial();
        Fact.Progression += new Factorial.ProgressEventHandler(Progress);
        Console.Write("\n" + "Partial results : ");
        Console.CursorLeft = 35;
        Console.Write("Progress : ");         
        int Result = Fact.CalculateFactorial(number, time);
        Console.WriteLine(" ");
        Console.WriteLine("The factorial of " + number + " is : " + Result);


        Console.ReadLine();
    }

    static int j;
    static int[] numbers;

    public static void Main(string[] args)
    {
        int i=0;
        bool ok = false;
        numbers = new int[10];
        Console.Write("Please insert wait time (0,1 or 2) : ");
        int time = int.Parse(Console.ReadLine()) * 1000;
        Console.Write("Please insert a number : ");
        do
            if (Console.ReadLine() != "")
            {
                i++;
                numbers[i] = int.Parse(Console.ReadLine());


            }
            else
            {
                ok = true;
            }
        while (ok == false);
        for (j = 1; j <= i; j++)
        {

            Calculate(numbers[j],time);
        }

    }
}

So things are a bit strange here… and it seems to come from the if(Console.Readline()!=””) condition.

So this program is supposed to calculate the factorial of several numbers. I give it a delay time in order to diplay the stack progress through percentage.

If I enter a random time and insert only two values the program will work, but only for the first number. If i enter more than 2 numbers I will get FormatException unhandled.

Now if I replace the condition with if(numbers[i]!=10) the program will work for any number of values, but 10! must be calculated.

How do I handle this problem? Am I missing something obvious?
Thanks in advance!

Answer 1

You’are reading the line twice. Change the code like this:

string line = string.Empty;
do
{
    line = Console.ReadLine();
    if (!string.IsNullOrEmpty(line))
    { 
       numbers[i] = int.Parse(line);
       i++;
    }
    else
    {
      ok = true;
    }

}while (!ok && i<10);

Should work for you.