Question

I have a ruby hash like this

h = {"a" => "1", "b" => "", "c" => "2"}

Now I have a ruby function which evaluates this hash and returns true if it finds a key with an empty value. I have the following function which always returns true even if all keys in the hash are not empty

def hash_has_blank(hsh)  
  hsh.each do |k,v|  
    if v.empty?  
      return true  
    end  
  end
  return false
 end

What am I doing wrong here?

Answer 1

Try this:

def hash_has_blank hsh
    hsh.values.any? &:empty?
end

Or:

def hash_has_blank hsh
    hsh.values.any?{|i|i.empty?}
end

If you are using an old 1.8.x Ruby