Question

I have an array of things, things = [1, 500, 900, 0, -105, -8, 16, 4] and I want to display them in red, green or black in my view based on whether they’re larger than zero, smaller than zero or equal to zero.

Right now my code looks like:

<%= @things.each do |p|%>
 <% if p > 0 %>
      <%= p  %>
    <% elsif p < 0 %>
      <%= p %>
    <% else %>
      <%= p %>
 <% end %>
<% end %>

I’m not displaying the numbers correctly to start, and I’ve gone through a few iterations of putting them in divs and nothing seems to work. Once I get ’em in classes, I can add colors pretty easily. (I also need to keep them in the same order they’re in in the array)

Any help would be greatly appreciated.

Answer 1

Not sure what’s the issue here

 <% @things.each do |p|
     if p < 0
       class_name = 'red'
     elsif p > 0 
       class_name = 'green'
     else 
       class_name = 'black'
     end %>
     <div class="<%=class_name%>"><%= p %></div> 
<% end %>

Then css :

.red{color:red;}
.green{color:green;}
.black{color:black;}

Edit : In your example, you were using <%= @things.each. Don’t use <%= for things that are not supposed to output anything