Question

I have the following:

if (model.PartitionKey.Substring(2, 2) == "05" || 
    model.PartitionKey.Substring(2, 2) == "06")

I have more like this. Is there a more clean way to code this where I don’t have to repeat model.PartitionKey twice ?

Answer 1

What about this:

if (new string[]{"05", "06"}.Contains(model.PartitionKey.Substring(2, 2))
    // ...

That leaves you at liberty to keep the strings you are looking for in a nice list…

var lookingFor = new string[]{"05", "06"};
var substring = model.PartitionKey.Substring(2, 2);
if (lookingFor.Contains(substring))
{
    // ...
}

This will help a lot if the list of strings you are looking for gets longer than just two… Also, you can then add this to a set (HashSet<string>) for more efficient lookup – but test this first, as overhead can eat up gains.