Question

If I generate a scaffold I get the standard actions index, new, show, create …. all of which contain a line e.g. like

@comment = Comment.find(params[:id])

Does it make sense to put this line in a seperate method into the controller like

def load
@comment = Comment.find(params[:id])
end

Is this an advantage? Thx for your time

Answer 1

Yes to the separate method, and also yes to using a before_filter.

class CommentsController < ApplicationController
  # Whitelist your before_filter like this. Or you can blacklist it with :except => []
  before_filter :load_comment, :only => [:edit, :update, :destroy, :show]

  def show
  end

  def index
    @comments = Comment.all 
  end

  def new
    @comment = Comment.new
  end

  # etc ...

  protected

  def load_comment
    @comment = Comment.find(params[:id])
  end
end