Question

im still fairly new to RoR, and as always looking for better, more efficient ways of coding. with the following line of code, is there possibly a better way of achieving the same result?

= "#{schedule.time.to_s(:event_date) + " @ " + schedule.time.to_s(:event_time) + " - " + (schedule.time + schedule.duration.to_i.minutes).to_s(:event_time)}"

which will output

Fri, 31 Aug, 2012 @ 10:40 PM - 11:40 PM

Answer 1

You can hide this complex line inside schedule helper, you can as well define schedule.end_time

module ScheduleHelper
  def schedule_time schedule
    html = ''
    html << schedule.time.to_s(:event_date)
    html << ' @ '
    html << schedule.time.to_s(:event_time)
    html << ' - '
    html << schedule.end_time.to_s(:event_time)
    raw html
  end
end

class Schedule
  def end_time
    self.time + this.duration.to_i.minutes
  end
end

<%= schedule_time schedule %>