Question

I’ve got a managed object with an NSNumber that’s just a Boolean value. When the user clicks a button I want to toggle that.

self.item.completed = [NSNumber numberWithBool:![self.item.completed boolValue]];

Is there a cleaner (or perhaps just more compact) way that I’m missing?

Answer 1

There is little you can do to the process of producing the negated value, but you can make the syntax of invoking it look less bulky by hiding your code in a category:

@interface NSNumber ( NegateBoolean )
-(NSNumber)negateBool;
@end

@implementation NSNumber ( NegateBoolean )
-(NSNumber)negateBool{
    return [NSNumber numberWithBool:![self boolValue]];
}
@end

Now you can use the new method like this:

self.item.completed = [self.item.completed negateBool];

You could also set up an NSArray with inversions, and use it as follows:

NSArray *inversions = [NSArray arrayWithObjects:[NSNumber numberWithBool:YES], [NSNumber numberWithBool:NO], nil];
self.item.completed = [inversions objectAtIndex:[self.item.completed boolValue]];