Question

I’ve got JavaScript code like this =>

(function(){
    document.getElementById("element").onclick = function(){
        var r = confirm("Are you sure ?");
        if (r){
            return true;
        } else {
            return false;
        }
    }
})();

this script works, but just gives me notification about Strict Warning that anonymous function doesn’t always return a value

I’m interested in what that means, how can I prevent this and will it provoke any problem ? Please any ideas ? thanks 🙂

Answer 1

It’s not because of the anonymous function, it’s because the else with that return is redundant. You don’t need it since return exits the function, if the if statement is not true then the default return will execute.

(function(){
    document.getElementById("element").onclick = function(){
        var r = confirm("Are you sure ?");
        if (r){
            return true;
        }
        return false;
    }
})();

Edit:

As nebulae said this can be done even shorter:

(function(){
    document.getElementById("element").onclick = function(){
        return confirm("Are you sure ?");
    }
})();