Question

Looks a newbie question, but this function is called many times, to be honest thousands of time per-second, so an optimization is CRUCIAL in here. What would be the best method?

struct CHOLDELEM
{
    DWORD dwColor[3], dwItemId[3];
    int nPos[3], nLength[3];
    CItemElem* pItem[3];
    CHOLDELEM()
    {
        for( int i=0; i<=3; i++ )
        {
            dwColor[i] = dwItemId[i] = 0;
            nPos[i] = nLength[i] = 0;
            pItem[i] = NULL;
        }
    }
};

or with memsets?

memset( dwColor, 0, sizeof( dwColor ) );

or another method.

Answer 1

As long as you are interested in zero initialization only, you can simply do

CHOLDELEM() : dwColor(), dwItemId(), nPos(), nLength(), pItem()
  {}

(no C++11 necessary).

However, you might want to take a look at the code your compiler generates for it. If it is not optimal somehow, then a better idea might be to keep your struct a POD (no constructor) and initialize it “from outside” when you declare objects of that type

CHOLDELEM c = {};