Home/ Questions/Q 1037075
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-16T14:48:31+00:00

<?php } elseif($_SOMETHING == 1 && $_ANOTHER_THING == 2) { ?> <?php $_NAME =

  • 0
<?php } elseif($_SOMETHING == 1 && $_ANOTHER_THING == 2) { ?>
<?php $_NAME = urlencode($_NAME); ?>
<?php $_MGT_NAME = urlencode($_MGT_NAME); ?>
</div>    
<?php } ?>

I am getting this error expected ‘;’

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    The horror. The horror.

    Here’s the actual error, in the onclick attribute value:

    lpButtonCTTUrl = 'http:...Ad%20Source=somesite.com& ='+escape(document.location); imageUrl=<?php print "http://{$_SERVER['SITENAME']}/images/";?>&referrer

    That is, there should be a +' instead of ; after the document.location inclusion, and there should be a closing quote after the imageURL inclusion, and referrer is in the wrong place (it should be just before the document.location inclusion.

    It also has problems like the use of escape (never use escape. For URL-encoding you actually want encodeURLComponent); the unescaped ampersands all over the place; and the lack of HTML- and URL-encoding of values output from PHP, potentially causing cross-site scripting risks.

    Writing a value inside a URL component inside a URL inside a JavaScript string literal inside an attribute value inside HTML is utter insanity so it’s no surprise there are mistakes. Let’s try to bring some maintainability to this madness. Break out the JavaScript and URL creation into separate steps where getting the escaping right is possible.

    function urlencodearray($a) {
    $o= array();
    foreach ($a as $k=>$v)
        array_push($o, rawurlencode($k).'='.rawurlencode($v));
    return implode('&', $o);
}
function h($s) {
    echo htmlspecialchars($s);
}

    With these utility functions defined, then:

    <?php } elseif($_SOMETHING == 1 && $_ANOTHER_THING == 2) { ?>
    <?php
        $lpbase= 'http://server.iad.liveperson.net/hc/84152841/?';
        $linkurl= $lpbase.urlencodearray(array(
            'cmd'=>'file',
            'file'=>'visitorWantsToChat',
            'site'=>'84152841',
            'byhref'=>'1',
            'skill'=>'somesiteILS',
            'SESSIONVAR!skill'=>'somesiteILS',
            'SESSIONVAR!Management Company'=>$_MGT_NAME,
            'SESSIONVAR!Community'=>$_NAME,
            'SESSIONVAR!Ad%20Source'=>'somesite.com',
            'imageUrl'=>"http://{$_SERVER['SITENAME']}/images/"
        ));
        $imgurl= $lpbase.urlencodearray(array(
            'cmd'=>'repstate',
            'site'=>'84152841',
            'channel'=>'web',
            'ver'=>'1',
            'skill'=>'somesiteILS',
            'imageUrl'=>"http://{$_SERVER['SITENAME']}/images/"
        ));
    ?>

    <div id="caller_tag">
        <a id="_lpChatBtn" target="chat84152841" href="<?php h($url); ?>">
            <img src="<?php h($imgurl); ?>" name="hcIcon" alt="Chat" border="0">
        </a>
        <script type="text/javascript">
            document.getElementById('_lpChatBtn').onclick= function() {
                var url= this.href+'&referrer='+encodeURIComponent(location.href);
                if ('lpAppendVisitorCookies' in window)
                    url= lpAppendVisitorCookies(url);
                if ('lpMTag' in window && 'addFirstPartyCookies' in lpMTag)
                    url= lpMTag.addFirstPartyCookies(url)
                window.open(url, this.target, 'width=475,height=400,resizable=yes');
                return false;
            };
        </script>
    </div>
    • 0