Question

This is part of larger graphing program (JavaPlot specifically). In a nut shell, I would try to graph something; the graph would appear at

out.write(comms); 

but then close once it hit

out.close()

I know you need to close OutputStreamWriter, so instead of removing that line, I created a Scanner that waits until the user presses ‘Q’ and then the program continues as normal, closes the graph, the OutputStreamWriter, and the Scanner

        OutputStreamWriter out = new OutputStreamWriter(proc.getOutputStream());
        out.write(comms);
        out.flush();

//added from here
        //waiting until input is given
        Scanner timeKiller = new Scanner(System.in);
        String check = timeKiller.nextLine();
        if(check != "q"){
            check = timeKiller.nextLine();  //<---waiting here. 
        }
        timeKiller.close();
//to here

        out.close();

Is what I’m doing dangerous? If someone closes the graph by closing the window, this won’t kill the program, correct? This won’t cause a memory leak (right?) but if the process is still running and they run this program several times, it will eventually start to be an issue. How can I fix this? Just off the top of my head, maybe add a listener to the window that breaks the loop if the window is closed? Or am I mistaken and this is isn’t an issue at all?

Answer 1

If you have flushed the stream / writer after the most recent write, then you won’t lose any data if you exit the application without calling close on the stream first. And if you are exiting the application, the JVM terminates and storage leaks become irrelevant.

On the other hand, if you don’t cause the application to exit when it arguably should exit, and the user spawns multiple instances as a result, you’ll have a problem with lots of JVMs filling up the user’s PC’s memory. If that happens, the hypothetical leaked stream is insignificant compared with dealing with the orphanned JVMs.

But it is really unclear from your question what you are actually doing and/or proposing to do, so I can’t really comment on your specific situation.