This title may sound a little bit crazy, but this is what is making me confused. My app heavily uses local database operations. As suggested in the Android docs and some blogs, I extended the SQLiteOpenHelper class and defined all my DB operations there. As some of my DB operations execute in threads, opening and closing of the db causes some IllegalStateExceptions. So, I made my DB helper as Singleton and it resolved those issues, also getting rid of the open and close operations for every DB action. Now everything seems to be working fine even though I never close the DB.
- My confusion is that is it necessary to close DB?
- If so, what is the right place to do so, is it in
onDestroyof the main activity or somewhere else? - If I don’t close DB, what are the side effects?
You can catch
IllegalStateExceptionif you’ll try to open again the same database.If you create instance of
DBHelperinonCreatemethod of main activity – it would be write to close db inonDestroy. So, you can be sure, that next time inonCreateyour database is not opened already.If you have reference to
DBHelperin service, than it should be opened and closed in service, and not in activity.You can also use
Applicationclass for opening db, but than it will opened every time when you app starts (for example when you receiveBroadcastReceiver)