Question

Trying to learn JavaScript, makin decent progress I guess, but I’m stuck at validating a form, tried to see if anybody has the same problem, search didn’t turn anything up. So would you please help me?

    var minlength = 6;
var pwlength = document.getElementById('psswrd');
var invalid = " ";

function validate() {

    if (pwlength.length < minlength && pwlength == invalid) {
        alert("Password not valid");

    else { 
        alert("Password okay!");
    }
}

submitbtn.onClick = validate();

Answer 1

• It is not obvious where you call this – I have wrapped it in a window.onload
• you do not access the button correctly. Either of
  document.forms[0].submitbtn
document.getElementById("submitbtn") or
  document.getElementsByName("submitbtn")[0] will work depending on how you name or ID the button HOWEVER do not assign onclick handlers to submit buttons, instead assign submit handler to the form
• there is no point of testing for a single space since that is less than 6 chars anyway.
• && is AND, you mean || OR
• onclick must be all lowercase.
• You assign the onclick to the result of validate instead of validate
• You do not stop the submission

I have taken the trim from here
and I assume the form has ID=”form1″

window.onload=function()
  document.getElementById("form1").onsubmit = validate;
}

if(typeof String.prototype.trim !== 'function') { // let's help older IEs
  String.prototype.trim = function() {
    return this.replace(/^\s+|\s+$/g, ''); 
  }
}

function validate() {
  var minlength = 6;
  var pw = document.getElementById('psswrd');
  if (pw.value.length < minlength || pw.value.trim() == "") {
    alert("Password not valid");
    pw.focus();
    return false;
  }
  return true; // allow submission  
}