Question

When programm execute this private method

map<char*, vector<MAILPACK>>::iterator mit;
vector<MAILPACK>::iterator dit;
for(mit=funcs.begin(); mit!=funcs.end(); mit++) {
    TRACE tr;
    tr.crc32 = crc32;
    strncpy(tr.name, (*mit).first, sizeof(tr.name));
    int i = 0;
    for(dit=(*mit).second.begin(); dit!=(*mit).second.end(); dit++){
        tr.nodes[i++] = dit->dwAddr;
    }       
}   

I get error like: Expression:map/set iterator not incrementable

This function iterate through private map std::map<char*, std::vector<MAILPACK>> funcs;

Where I’m wrong?
Thx

P.S. oh, I found that I didn’t control boundaries when saving addresses into tr.nodes.
But this is not the point…

Answer 1

Some typedef‘s wouldn’t go astray. And pre-increment your iterators, avoiding useless iterator object copies.

typedef vector<MAILPACK> Mailpacks;
typedef map<char*, Mailpacks> MailpackMap;

for(MailpackMap::iterator mit=funcs.begin(); mit!=funcs.end(); ++mit) 
{
  TRACE tr;
  tr.crc32 = crc32;
  strncpy(tr.name, (*mit).first, sizeof(tr.name));
  int i = 0;
  Mailpacks& mail = (*mit).second;
  for(Mailpacks::iterator dit= mail.begin(); dit!=mail.end(); ++dit)
  {
    tr.nodes[i++] = dit->dwAddr;
  }       
}

I agree with @Chowlett, and think you’re stomping out of your tr.nodes bounds and over one of your iterators. Since you are instantiating your TRACE object during the loop, there is a good chance this is happening. You will usually get the Expression:map/set iterator not incrementable error when your iterator has been invalidated.

Is there any reason you’re tr.nodes member can’t be a vector too?

tr.nodes.push_back(dit->dwAddr);

I could be wrong, more information always helps.