Question

Which one is better to use when it come to return value for example

public int EmployeeAge
{
    get{return intEmployeeAge};
}

And

public int EmployeeAge()
{
    return intEmployeeAge;
}

Which one is better and why? And what is best programming practice to use when we have secnario like above ?

Answer 1

Properties are a useful way of expressing a feature of an object, allowing get/set in a common way that can be used by APIs like data-binding, reflection and serialization. So for simple values of the object, properties are handy. Properties can’t take arguments, should not have significant side-effects*, and should return quickly and repeatably. Also, there is no such thing as an “extension property” (to mirror an extension method) nor a generic property.

(*=lazy loading etc isn’t uncommon, however)

Methods (C# doesn’t have functions) are better for expressing things that either change the state, or which have an expectation of taking some time and not necessarily being reproducible. They don’t tend to work in binding / serialization etc.

Note that properties are actually just a special way of writing methods. There is little functional difference. It is all about expressing intent. The one thing you don’t want to expose, however, is fields (the actual intEmployeeAge instance variable).

So I would have:

public int EmployeeAge { get{return intEmployeeAge}; }

or just (if on the Employee object):

public int Age { get{return intEmployeeAge}; }

Of course… then the question becomes “in what unit?” I assume that is years?