Question

A little background on what I’m doing.
I have a button that has a click call which takes me to this code.

  static public DataSet shareFiles(TransitoryRegObj argTransRegObj)
{
    string sqlString = "do_share_files"; // it's a stored procedure
    SqlConnection cnn = new SqlConnection(masterConn);
    SqlCommand comm = new SqlCommand(sqlString, cnn);
    DataSet ds = new DataSet();

    try
    {
        cnn.Open();
        SqlCommand Comm = new SqlCommand(sqlString, cnn);
        Comm.CommandType = CommandType.StoredProcedure;


        comm.Dispose();
        cnn.Close();

        return ds;
    }
    catch (Exception ex)
    {
        // log here should anything go wrong with anything
        //  lblmessage.Text = "Error: " + ex.Message;



        if (comm != null)
            comm.Dispose();

        if (cnn != null)
            cnn.Close();

        DataTable dt = new DataTable("ExceptionTable");
        dt.Columns.Add("ExceptionMessage");
        dt.Rows.Add(ex.Message);
        ds = new DataSet();
        ds.Tables.Add(dt);
        return ds;
    }
}

The code runs fine however nothing is written to database. here is do_share_files stored procedure.

  ALTER PROCEDURE [dbo].[do_share_files] 
   --@device_id bigint, @user_id bigint, @file_name varchar(50),@full_up_path varchar(50), @upLength varchar(30)
    --,@mime_type varchar(20), @filedate varchar(30)

    AS
    BEGIN
        insert into [user_files] (device_id, user_id, original_name, original_path, up_path, content_type, up_dt)
        values (17, 30, 'test.pg', 'test.pg', 'test.pg','test.pg', '2012-11-15 03:58:06.043')


    END

I have static values for now since i’m just trying to get it to run to stored procedure.
I’m new to asp.net and don’t know what i’m doing wrong. Any help would be appreciated.

Thanks!

Answer 1

You could start with this:

static public DataSet shareFiles(TransitoryRegObj argTransRegObj)
{
    string sqlString = "do_share_files"; // it's a stored procedure
    DataSet ds = new DataSet();

    try
    {
        using (var cnn = new SqlConnection(masterConn))
        { 
            SqlCommand comm = new SqlCommand(sqlString, cnn);
            comm.CommandType = CommandType.StoredProcedure;
            cnn.Open();
            comm.ExecuteNonQuery ();

To summarize:

1. Comm and comm are different commands;
2. To run the proc, you need to call ExecuteNonQuery or other Execute method.