Question

according to Eric Gunnerson

Don’t

• Use lock(this)
• Use lock(typeof())

Do
Lock on a private variable, not on something the user can see
Use “object key = new object()” if you need a private key to lock on

what is the reason??

Answer 1

what is the reason??

Because anything that is not private means that could be used from the outside to lock on by someone else or some code that is outside from your control leading to deadlocks.

The best practice is to lock on private static variables, like this:

private static object _syncRoot = new object();

and then:

lock(_syncRoot)
{
    ...
}

private instance variables could also be dangerous since the instance of your class is not something that you as implementer of the class own. It’s the consumer of the class that owns the instance.