Question

All of the code in my project is procedural. It isn’t using any framework, or any MVC structure. Most of the PHP is form handlers with some logic. So lots of code like this:

<?php

require "headerFile.php";

$user = array(); // filled with user data

if (isset($_POST['submitButton'])) {
    if (isset($_POST['money'])) {
        if (is_numeric($_POST['money'])) { // I don't actually validate numbers this way
            if ($_POST['money'] <= $user['money']) {
                $query = mysql_query("SELECT * FROM someTable WHERE id={$user['id']}");

                if($result = mysql_fetch_array($query)) {
                    if ($someOtherCheck == $user['someOtherData']) {
                        /*
                         * run some queries, give user some item
                         *
                         */
                    } else {
                        echo "This isn't right.";
                    }
                } else {
                    echo "You don't have a row in some table!";
                }
            } else {
                echo "You don't have that much money!";
            }
        } else {
            echo "Enter a valid number";
        }
    } else {
        echo "Enter how much you want to wager.";
    }
}

// some hard coded form goes here

require "footerFile.php";

?>

There are over a hundred of these forms and nested if handlers, some that are similar with more/fewer conditions.

I want to start using OOP and I’ve been reading up on design patterns but I can’t seem to find anything that applicable to my project.

I’m adding loads of new blocks of code similar to the block above, I don’t want to copy and paste and just change a couple of bits here and there, what are my options?

Answer 1

I want to start using OOP and I’ve been reading up on design patterns but I can’t seem to find anything that applicable to my project.

You don’t have to start with patterns yet .. understand the basics and you can progress form there ..

This is a basic example

if (isset($_POST['submitButton'])) {

    $db = new \mysqli("localhost", "user", "pass", "db");

    $user = new User("Juddling Stack", 123456);
    $user->setMoney(500.01);

    $player = new PlayerRegister($db, $user);

    if (! isset($_POST['money']) || ! is_numeric($_POST['money']))
        $player->addError("Enter Valid Wager Money");

    if ($_POST['money'] <= $user['money']) {
        $player->addError("You don't have that much money!");
    }

    try {
        $player->doSQL();
    } catch ( BaseException $e ) {

        foreach ( $e->getError() as $error ) {
            echo $error, " <br />";
        }
    }
}

Classes Used