Question

Am I comparing the pipe symbols |x| & |f| correctly below ?

|f| corresponds to the name of a dir
|x| corresponds to the name of a file

  Dir.foreach(@sortedFilesDir) do
  |f|
    @fileArray.each() {
      |x| 
      if(x.match(/^#{f}/))
        puts "match - "+x+","+f
      end
    }
  end

Answer 1

I’ve made a few changes:

1. I made the variable names more informative
2. I replaced the regular expression with String#start_with?
3. I made the code more functional-programming than imperative programming, by replacing two eachs with a map and a find.
4. I used “#{expression}” rather than "match - "+x+","+f

I haven’t checked that it works, though.

directory_names = Dir.foreach(@sorted_files_dir)
matching_directory_names = @file_array.map do |filename|
  directory_names.find do |directory_name|
    filename.start_with?("/" + filename + "/")
  end
end
@file_array.zip(matching_directory_names) do |filename, matching_directory_name|
  next if matching_directory_name.nil?
  puts "match - #{filename},#{matching_directory_name}"
end

I hope directory_names doesn’t get calculated every time the loop gets run! If it does, then you might want directory_names = Dir.foreach(@sorted_files_dir).to_a at the start of the script.