Question

ANSWER:

Needed the call to getExternalFilesDir(p); like so:

String p = thepathblah; 
File path=context.getExternalFilesDir(p);

EDIT EDIT:

While I knew the Environment.DIRECTORY_PICTURES was returning just Pictures/ I figured this worked because in android I assumed the file pointer was already pointing to your application space (sorta like in c#). So in this:

 String p = Environment.DIRECTORY_PICTURES + "/" + s.getClient().getFirstName()+s.getClient().getLastName() +
 "/" + s.getPackage().getName() +
 (mSession.getSessionDate().getMonth()+1)  +  
 mSession.getSessionDate().getDate() +  
  (mSession.getSessionDate().getYear()+1900);

I thought was getting the full path, in fact I was writing a file out to this with no issues. It turns out though to delete individual files (and load them) I needed a fuller path which ended up being:

 String p = Environment.DIRECTORY_PICTURES + "/" + s.getClient().getFirstName()+s.getClient().getLastName() +
 "/" + s.getPackage().getName() +
 (mSession.getSessionDate().getMonth()+1)  +  
 mSession.getSessionDate().getDate() +  
  (mSession.getSessionDate().getYear()+1900);

 File dir = new File("/sdcard/Android/data/com.software.oursoftware/files/"+p);

Not sure if I can take it that the above link is valid for all Honeycomb devices or not, specifically the /sdcard/Android/data/packagespace/files/

Is this safe to use this or do I have to do something more dynamic for honeycomb devices???

EDIT: This is my little test function code to just write something to a folder…

   String p = Environment.DIRECTORY_PICTURES + "/" + s.getClient().getFirstName()+s.getClient().getLastName() + "/" + s.getPackage().getName() + (mSession.getSessionDate().getMonth()+1)  +  mSession.getSessionDate().getDate() + (mSession.getSessionDate().getYear()+1900);
            File path = mContext.getExternalFilesDir(p);
            File file = new File(path, "DemoPicture.jpg");

            try {
                // Very simple code to copy a picture from the application's
                // resource into the external file.  Note that this code does
                // no error checking, and assumes the picture is small (does not
                // try to copy it in chunks).  Note that if external storage is
                // not currently mounted this will silently fail.
                InputStream is = getResources().openRawResource(R.drawable.ic_contact_picture);
                OutputStream os = new FileOutputStream(file);
                byte[] data = new byte[is.available()];
                is.read(data);
                os.write(data);
                is.close();
                os.close();

                // Tell the media scanner about the new file so that it is
                // immediately available to the user.
                MediaScannerConnection.scanFile(mContext,
                        new String[] { file.toString() }, null,
                        new MediaScannerConnection.OnScanCompletedListener() {
                    public void onScanCompleted(String arg0, Uri arg1) {
                         Log.i("ExternalStorage", "Scanned " + arg0 + ":");
                            Log.i("ExternalStorage", "-> uri=" + arg1);

                    }
                });
            } catch (IOException e) {
                // Unable to create file, likely because external storage is
                // not currently mounted.
                Log.w("ExternalStorage", "Error writing " + file, e);
            }

Then the way I try to delete this folder:

String p = Environment.DIRECTORY_PICTURES + "/" + firstName+lastName +"/" + pName+pDate;
File dir=new File(p); 
deleteRecursive(dir);

results in

Pictures/ShaneThomas/Portrait882011/

Which can write a file, tested that, but if I try to say:

void deleteRecursive(File dir)
{
    Log.d("DeleteRecursive", "DELETEPREVIOUS TOP" + dir.getPath());
    if (dir.isDirectory())
    {
        String[] children = dir.list();
        for (int i = 0; i < children.length; i++) 
        {
           File temp =  new File(dir, children[i]);
           if(temp.isDirectory())
           {
               Log.d("DeleteRecursive", "Recursive Call" + temp.getPath());
               deleteRecursive(temp);
           }
           else
           {
               Log.d("DeleteRecursive", "Delete File" + temp.getPath());
               boolean b = temp.delete();
               if(b == false)
               {
                   Log.d("DeleteRecursive", "DELETE FAIL");
               }
           }
        }

        dir.delete();
    }
}

The dir.isDirectory is always false!? I got this delete file/directories code off stack overflow but am puzzled as to why its not working?

and I do have this set:

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>

Answer 1

I think you want to add

dir.mkdirs() right after File dir=new File(p). mkdirs() is the method responsible for actually creating a directory, not new File().