Question

as a part of a homework assignment, I’m trying to read a single char from stdin, and act according to it:

char choice;

while (1) {
    printf("please enter [y]es, [n]o or [m]aybe: ");
    scanf("%c", choice);
    fflush(stdin);
    // validate input
    if (choice == 'y' || choice == 'n' || choice == 'm') {
        break;
    } else {
      printf("Please enter only \'y\', \'n\' or \'m\'!\n");
    }
}
// do something with the input
if (choice == 'y') {
    printf("you selected yes!\n");
}

for some reason, scanf captures both the char and the line-feed after, thus it proceeds to do something with the input and then also prints the “Please enter only ‘y’, ‘n’ or ‘m’!” line. If I enter several characters on the stdin, it will print that line for all of them, while also performing correctly for the first char. So, for example:

$ ./run
please enter [y]es, [n]o or [m]aybe: y<return>
you selected yes!
Please enter only 'y', 'n' or 'm'!
$ ./run
please enter [y]es, [n]o or [m]aybe: yes<return>
you selected yes!
Please enter only 'y', 'n' or 'm'!
Please enter only 'y', 'n' or 'm'!
Please enter only 'y', 'n' or 'm'!
$

Same thing happens if I use getchar. What am I missing? thanks.

Answer 1

You need a space between scanf(" and the %c for it to work correctly:

scanf(" %c", &choice);

And you also need to use &choice, not choice!

EDIT: While you’re at it, you might want to look into do while() for that loop (unless the professor specifically said to use a break) – do while works great when validating user input!