Question

At the moment I write stored procedures this way:

create proc doStuff
@amount int
as
begin try
begin tran
...
if something begin  select 'not_good' rollback return end
if someelse begin  select 'some_other_thing' rollback return end
--do the stuff
...
commit 
end try
begin catch 
if @@trancount > 0 rollback
select 'error'
end catch

the problem with this approach is that I hide the error, anybody knows to do this some other ?

Answer 1

SQL server sp.

create procedure doStuff
(
   @amount int
) 
as
begin try
   begin transaction

    if something
        raiserror('not_good', 16, 1)

    if somethingelse
        raiserror('some_other_thing', 16, 1)

    do stuff here

   commit
end try
begin catch
    if @@trancount > 0
        rollback

    declare @errmsg nvarchar(4000), @errseverity int
    select @errmsg = error_message(), @errseverity = error_severity()

    raiserror(@errmsg, @errseverity, 1)
end catch