Question

Background: I’m developing a WinForms application using C# with an OpenFileDialog & FileBrowserDialog that will 1) search for a specific string in the filenames of a specified source directory 2) copy files to consolidated directory 3) convert multiple files from excel to csv files, and then 3) convert all the generated csv files into 1 big csv file using a command line executable

Example: MSDN provides a code example that lists all of the directories and files that begin with the letter “c” in “c:\”. at http://msdn.microsoft.com/en-us/library/ms143448.aspx so I based my code on that…

Problem: The code doesn’t copy any files to the consolidated folder so I’m pretty sure the search doesn’t work.

What should I change on here? It doesn’t work :

    string files = "*.xlsx";
    void DirSearch(string sDir)
    {
        try
        {
            foreach (string d in Directory.GetDirectories(sDir))
            {
                foreach (string f in Directory.GetFiles(d, files))
                {
                    // Is this the file we are looking for?
                    // check excel files for corp name in the filename.
                    if (f.Contains(m_sc.get_Corp()))
                    {
                        // check if thread is cancelled
                        if (m_EventStop.WaitOne(0, true))
                        {
                            // clean-up operations may be placed here
                            // ...

                            // inform main thread that this thread stopped
                            m_EventStopped.Set();

                            return;
                        }
                        else
                        {
                            string path = sDir;
                            string searchPattern = m_sc.get_Corp();

                            // A file has been found in this directory
                            DirectoryInfo di = new DirectoryInfo(path);
                            DirectoryInfo[] directories = di.GetDirectories(searchPattern, SearchOption.TopDirectoryOnly);

                            foreach (FileInfo file in files)
                            {

                              try
                              {
                              // Copy each selected xlsx files into the specified TargetFolder 

                              System.IO.File.Copy(FileName, consolidatedFolder + @"\" + System.IO.Path.GetFileName(FileName));
                              Log("File" + FileName + " has been copied to " + consolidatedFolder + @"\" + System.IO.Path.GetFileName(sourceFileOpenFileDialog.FileName));

                             // Convert each selected XLSX File to CSV Using the command prompt code... 
                              }
                            }
                       }
                  }

Answer 1

The code you’ve posted does two separate search loops:

first:

    foreach (string d in Directory.GetDirectories(sDir))
    {
        foreach (string f in Directory.GetFiles(d, files))
        {
            // Is this the file we are looking for?
            // check excel files for corp name in the filename.
            if (f.Contains(m_sc.get_Corp()))
            {

then within that it also does:
string path = sDir;
string searchPattern = m_sc.get_Corp();

                        // A file has been found in this directory
                        DirectoryInfo di = new DirectoryInfo(path);
                        DirectoryInfo[] directories = di.GetDirectories(searchPattern, SearchOption.TopDirectoryOnly);

                        foreach (FileInfo file in files)
                        {

In the first one you are looking for files matching m_sc.get_Corp();, in the second one you are lookinf for directories…

In fact… your code (pseudo-code?) makes no sense…

Try:

• taking your time
• tidying up the code yourself
• if you rewrite it slowly and break this into smaller chunks, you might spot what you are doing wrong.