Question

Basically I have a main form which upon loading, opens a child form for logging in the user. When they cancel or close this login form, I need to close the whole application.

But there seems to be a few different ways to close a C# program:

1. Application.Exit();

2. Application.ExitThread();

3. Environment.Exit(1);

4. Process.GetCurrentProcess().Kill();

5. SFTPClient.LDAPLoggedIn = false; Close();

EDIT: Sorry if this one is not clear: It sets a property in a controller object to indicate that the login failed. After opening the child form, I would check this property in the parent form to see whether the program should continue or not. It basically shifts the responsibility of exiting the program to the parent without an exception.

6: throw new Exception("User closed the form");

I can see that there are two ways of handling it:

• Informing the parent that something went wrong (as in 5 and 6.)
• Closing the program from the child form.

Is either of these two considered better practice?

Each approach seems to have the same effect on my program but how do they actually compare?

UPDATE:
Thanks for the answers. For those searching this question in the future and curious people, this was my solution in the end:

private void FormMain_Load(object sender, EventArgs e)
{
    if (new FormLogin().ShowDialog(this) == DialogResult.Cancel) Close();
}

and:

private void buttonCancel_Click(object sender, EventArgs e)
{
    Close();
}

I discovered that when a form is closed via clicking the ‘X’, DialogResult is set to Cancel automatically so all I need to do is Close()

Answer 1

If you are wanting to gracefully handle the exception in the last case, that’s ok (not great though) – as long is it is an exceptional situation to your application. Otherwise I’d create a new method that shows the form as a dialog with a boolean. If the boolean comes back false (aka, user closed the form) I would then handle the application shut down from there (Using Application.Exit()).

It is, in my humble opinion, very bad practice to close the application from a child rather than telling the parent. The only time I agree with this is in a FailFast situation, which are very rare.

---

• Application.Exit();

This method stops all running message loops on all threads and closes all windows of the application. This method does not force the application to exit. The Exit method is typically called from within a message loop, and forces Run to return. To exit a message loop for the current thread only, call ExitThread.

• Application.ExitThread();

See above.

---

• Environment.Exit(1);

Terminates this process and gives the underlying operating system the specified exit code.

---

• Process.GetCurrentProcess().Kill();

Kill forces a termination of the process, while CloseMainWindow only requests a termination. When a process with a graphical interface is executing, its message loop is in a wait state. The message loop executes every time a Windows message is sent to the process by the operating system.

---

• SFTPClient.LDAPLoggedIn = false; Close();

After the clarification in the comment (passes flow back to the parent and handles from there), this is by far the best way of doing this.

---

• throw new Exception("User closed the form");

Throws an exception to the calling process. If this is the main thread, it will throw the exception in a very ugly way.