Question

Below code generates:

Unhandled exception at 0x749ab763 in MyProgram1.exe: 0xC0000005: Access violation writing location 0x00d4eb38.

    SECURITY_ATTRIBUTES sa = {0};
    sa.nLength = sizeof(sa);
    STARTUPINFO si = {0};
    si.cb = sizeof(si);
    //si.cbReserved2 = sizeof(si);
    si.lpDesktop = L"winsta0\\default";

    CreateProcessAsUser(hUserTokenDup, NULL, L"Setup.exe", &sa, &sa, false, NORMAL_PRIORITY_CLASS | CREATE_NEW_CONSOLE, NULL, NULL, &si, &procinfo);

Is there anything wrong with the code? Please help

Answer 1

From CreateProcessAsUser(), referring to the third parameter:

The Unicode version of this function, CreateProcessAsUserW, can modify the contents of this string. Therefore, this parameter cannot be a pointer to read-only memory (such as a const variable or a literal string). If this parameter is a constant string, the function may cause an access violation.

Change to:

WCHAR exeName[] = L"Setup.exe";

and pass exeName as the third parameter instead.