Home/ Questions/Q 4246044
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-21T03:55:15+00:00

Below is my code in a single PHP file named testOne.php <html> <head> <script

  • 0

Below is my code in a single PHP file named testOne.php

<html>
<head>
     <script type="text/javascript">
          function testAlert(firstValue, secondValue)
          {
               alert ("Passed: "+firstValue+secondValue);
          }
     </script>
</head>
<body>
  ....
</body>
</html>

<?php
     function testPassedValues($One, $Two)
     {
        echo "<input type = \"button\" onclick = \"testAlert($One[2], $Two[2])\">Click Here!</input>";
     }

     $link = mysql_connect("localhost", "root", "");
     if (mysql_select_db("myDatabase", $link))
     {
         $result = mysql_query("SELECT * FROM MYTABLE");
         while($currRowOne = mysql_fetch_row($result) &&
               $currRowTwo = mysql_fetch_row($result))
         {
             testPassedValues($currRowOne, $currRowTwo);
         }
     }
?>

To help in understanding, I am calling a javascript method testAlert() from the PHP function testPassedValues(). However, I am not sure what the issue is since the call is not successful. In Mozilla(Firebug), I don’t find any issues and in Chrome->Developer Tools, I get the error Uncaught Syntaxerror: Unexpected token ILLEGAL in the console.

Can anyone please help me as to the root cause here?

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    Most likely the values of $One[2] and $Two[2] are strings, so the generated HTML is:

    <input type = "button" onclick = "testAlert(string one, string two)">Click Here!</input>

    Which is obviously invalid javascript.

    Enclose the parameters in quotes:

    echo "<input type = \"button\" onclick = \"testAlert('$One[2]', '$Two[2]')\">Click Here!</input>";

    You should also correctly escape the of $One[2] and $Two[2] values for HTML and JavaScript, so that you don’t introduce XSS flaws or errors when a string contains an apostraphe. I’ll leave that up to you to figure out.

    • 0