Question

Below is my code. The operat function is not working properly. Any help will be appreciated. Normally, sort sorts in ascending order. I want to define operat such that it sorts in descending order

#include<iostream>
#include<cstdio>
#include<algorithm>
#include<vector>
#include<utility>
using namespace std;
typedef pair<int,int> pii;
typedef pair<int,pii> pwp;

bool operat(pwp a, pwp b){
    if(a.first > b.first){
        return true;
    }else if(a.second.first > b.second.first) {
        return true;

    }else if (a.second.second > b.second.second) { return true;}
    return false;

}
int main(){
    vector<pwp> inp;
    pwp obj1 = make_pair(1998,make_pair(3,24));
    pwp obj2 = make_pair(1998,make_pair(3,21));
    pwp obj3 = make_pair(1997,make_pair(3,24));
    inp.push_back(obj1);
    inp.push_back(obj2);
    inp.push_back(obj3);
    printf("Before sorting\n");
    for(int i = 0 ; i< inp.size();i++){
        pwp sth = inp[i];
        printf("%d %d %d\n",sth.first,sth.second.first,sth.second.second);

    }
    sort(inp.begin(), inp.end(),operat);
    cout<<"After soring"<<endl;
    for(int i = 0 ; i< inp.size();i++){
        pwp sth = inp[i];
        printf("%d %d %d\n",sth.first,sth.second.first,sth.second.second);
    }
return 0;
}

New one:

bool operat(pwp a, pwp b){
    if(a.first > b.first){
        return true;
    }else if(a.first <  b.first) return false;

    else if(a.second.first > b.second.first) {
        return true;

    }else if (a.second.first < b.second.first) return false;
    else if (a.second.second > b.second.second) { return true;}
    return false;

}

Answer 1

In your code:

bool operat(pwp a, pwp b){
    if(a.first > b.first){
        return true;
    }else if(a.second.first > b.second.first) {
        return true;
    }else if (a.second.second > b.second.second) { return true;}
    return false;
}

the second comparison should only be performed if a.first == b.first and the third only if also a.second.first == b.second.first