Question

Below is some core graphics code..

        CGColorRef colorRefArray[MAGIC_NUM];

        for (int i = 0; i < MAGIC_NUM ; i++)
        {
           ...

           colorRefArray[i] = CreateColor(colorValueForEachColor, numberofcomp);                
        }

colorRefArray already has memory and CreateColor(); will again create a memory and it leads to memory leak.

How do I avoid this situation?

One possible thought I have is

            CGColorRef colorRefArray[MAGIC_NUM];

            for (int i = 0; i < MAGIC_NUM ; i++)
            {
               ...
               CGColorRef colorref = CreateColor(colorValueForEachColor, numberofcomp);
               colorRefArray[i] = colorref;
               CFRelease(colorref);

            }

Is this approach correct?

Answer 1

No it’s not. You’re immediately releasing the color you created. The correct approach would be this:

 CGColorRef colorRefArray[MAGIC_NUM];
 for (int i = 0; i < MAGIC_NUM ; i++)
 {
     ...
    colorRefArray[i] = CreateColor(colorValueForEachColor, numberofcomp);                
 }
 //Use your colors
 //Now release them
 for (int i = 0; i < MAGIC_NUM ; i++)
 {
    CFRelease(colorRefArray[i]);
 }