Question

bool foo = true;

// Do this?
if (foo)
{
}

// Or this?
if (foo == true)
{
}

I like one of them and my coworker the other. The result is the same, but what is (more) correct?

Answer 1

Almost everyone I’ve seen expressing an opinion prefers

if (foo)
{
}

Indeed, I’ve seen many people criticize the explicit comparison, and I may even have done so myself before now. I’d say the “short” style is idiomatic.

EDIT:

Note that this doesn’t mean that line of code is always incorrect. Consider:

bool? maybeFoo = GetSomeNullableBooleanValue();
if (maybeFoo == true)
{
    ...
}

That will compile, but without the “== true” it won’t, as there’s no implicit conversion from bool? to bool.