Question

Can anyone explain to me why im getting a “.exe has encountered a problem and needs close”error, it compiles and works sometimes when i fiddle with the char array, but when it does work i sometimes get strange characters at the end of the string.

    #include <iostream>
using namespace std;
char* StrReverse3(char*);
char* StrReverse3(char* str)
{
    char *p;

    int length=0,start=0,end=0;
    length=strlen(str);

    for(start=0,end=length-1;end>= 0,start<=length-1;end--,start++)
    {
        p[start]=str[end];
    }   


    return p;
}
int main()
{
  char str[100]="Saw my reflection in snow covered hills";
  StrReverse3(str);

cin.get();
return 0;
}

Answer 1

You are not initializing p. It’s an uninitialized pointer that you are writing to.

Since you are writing this in C++, not C, I’d suggest using std::string and std::reverse:

#include <string>
#include <algorithm>
#include <iostream>

int main()
{
    std::string str = "Saw my reflection in snow covered hills";
    std::reverse(str.begin(), str.end());
    std::cout << str;
    return 0;
}

Output:

sllih derevoc wons ni noitcelfer ym waS

See it working online at ideone