Question

Can anyone see any issues with the code below? It’s my save function for a model it gives them a GUID on first save. My my problem is when I save a new recipient (in the admin) it overwrites the last one added. Updates seem to work perfectly tho.

part of Models.py

class GUID():
    make = hashlib.sha1(str(random.random())).hexdigest()


def save(self, *args, **kwargs):
    if not self.recipientid:
        self.recipientid = GUID.make
    super(Recipient, self).save(*args, **kwargs)

Answer 1

GUID.make will be set at the time the GUID class is created, it won’t re-calculated each time it’s run. I don’t know the rest of the context of how you’re using GUID, but I’d have it be a function:

class GUID(object):
    @staticmethod
    def make():
         return hashlib.sha1(str(random.random())).hexdigest()

...

def save(self, *args, **kwargs):
    if not self.recipientid:
        self.recipientid = GUID.make()
    super(Recipient, self).save(*args, **kwargs)