Question

Can anyone tell me whats wrong with this code, im validating a form making sure all the fields have text in them before anyone can submit. everything works until i put in the !='' var. I am sure the id’s are correct

<script src="jquery.js" type="text/javascript" language="javascript"></script> 
<script language="javascript">


$(document).ready(function() {

// declare the flags outside the other functions

 var username_ready = false;
 var email_ready = false;




function checkSubmitStatus() {
var emailvalue = $("#email").val();
 var usernamevalue = $('#username').val();
 var firstvalue = $('#first').val();
 var lastvalue = $('#last').val();
 var passwordvalue = $('#password').val();
if (username_ready && email_ready && emailvalue!='' && usernamevalue!='' &&  firstvalue!='' && lastvalue!='' && passwordvalue!=''){ 

  $("#register").prop('disabled',false); 
}
else {$("#register").prop('disabled',true);}
}

and here is my form code so you can see if thats the issue…

<p>First Name: <input id="first" type="text" name="name" maxlength="100"> </p>
<p>Last Name: <input id="last" type="text" name="name" maxlength="100"> </p>
<p> Email: <input type="text" name="email" id="email" maxlength="100" />
<span id="box" style="display:none"></span></p>
User Name : <input name="username" type="text" id="username" value="" maxlength="15" />
<span id="msgbox" style="display:none"></span>
<p> Password: <input id="password" type="password" name="password"> </p>

Answer 1

You spelt your variable name firstvalue incorrectly:

firstvale!=''

Edit

Move these 5 lines:

 var emailvalue = $("#email").val();
 var usernamevalue = $('#username').val();
 var firstvalue = $('#first').val();
 var lastvalue = $('#last').val();
 var passwordvalue = $('#password').val();

From where they are to right under function checkSubmitStatus(){ and above your big if statement.

Where they are now, they are only assigned once, to the value of the form when the page first loads which I’m assuming at least one of them is empty.

You need to move those lines into your checkSubmitStatus() function so that they get updated whenever the function is called. The final result should look like:

var username_ready = false;
var email_ready = false;

function checkSubmitStatus() {

    var emailvalue = $("#email").val();
    var usernamevalue = $('#username').val();
    var firstvalue = $('#first').val();
    var lastvalue = $('#last').val();
    var passwordvalue = $('#password').val();


    if (username_ready && email_ready && 
        emailvalue!='' && usernamevalue!='' &&
        firstvalue!='' && lastvalue!='' && passwordvalue!=''){ 

        $("#register").prop('disabled',false); 
    } else {
        $("#register").prop('disabled',true);
    }
}