Question

Can I do the following?

function contains(element) {

 // if the element is a Vertex object, do this
 if (element instanceof Vertex) {

  var vertex = element;
  for ( var index in self.verticies) {
   if (self.verticies[index].id == vertex.id) {
    return true;
   }
  }
  return false;
 }
 // else if the element is an Edge object, do this 
 else if (element instanceof Edge) {

  var edge = element;
  for ( var index in self.verticies) {
   if (self.verticies[index].id == edge.id) {
    return true;
   }
  }
  return false;
 } else {
  // shouldn't come here
  return false;
 }
};

Basically… I want to be able to call contains() and pass it either a Vertex object or an Edge object but I don’t want to have duplicate code. Is this the right way to do it? Furthermore, am I handling the assignment var vertex = element / var edge = element correctly? I want to assign element to another Vertex/Edge object and use that for my look up.

Let me know if I need to clarify.

Thanks,
Hristo

Answer 1

Your code should work fine.

Note, however, that there is no point (other than clarity, which is a good thing) in writing var edge = element.
Javascript variables are untyped; there is no difference between edge and element.

Also, you should probably throw an exception instead of

// shouldn't come here
return false;

Finally, why are you searching self.verticies for an Edge?

Note, by the way, that you still have duplicate code.
You can rewrite your function like this:

function contains(element) {
    var searchSet;

    // if the element is a Vertex object, do this
    if (element instanceof Vertex) 
        searchSet = self.verticies;
    else if (element instanceof Edge)
        searchSet = self.edges;
    else
        throw Error("Unexpected argument");

    for (var i = 0; i < searchSet.length; i++) {
        if (searchSet[i].id == element.id) 
            return true;
    }
    return false;
}