Question

Can I get a list of issues with the code below, and fixes?

 string ProgramID = HttpContext.Current.Session[CommonFunctions.myNGconnectSessionVars.ProgramId].ToString();
            SqlConnection con = new SqlConnection(ConfigurationManager.AppSettings["MyNGConnectDashBoardConnectionString"].ToString());
            SqlCommand cmd = new SqlCommand();
            DataSet ds = new DataSet();
            try
            {
                cmd.Connection = con;
                cmd.CommandTimeout = 900;
                cmd.CommandText = "dsb_GetSubscriptionDetailsForSubscriber_ForValidations";
                cmd.CommandType = CommandType.StoredProcedure;
                cmd.Parameters.Clear();
                cmd.Parameters.AddWithValue("@GPCustomerID", strGPCustomerID);
                cmd.Parameters.AddWithValue("@UserName", strUserName);
                cmd.Parameters.AddWithValue("@ServerName", ConfigurationManager.AppSettings["ServerName"].ToString());
                //code changed by sushma 3/22/2011 as new tab added for reach
                //cmd.Parameters.AddWithValue("@ProgramID", CommonFunctions.ProgramID);
                cmd.Parameters.AddWithValue("@ProgramID", ProgramID);
                cmd.Parameters.AddWithValue("@IsTeacher", blnIsTeacher);
                // cmd.CommandTimeout = 0;
                SqlDataAdapter da = new SqlDataAdapter(cmd);
                da.Fill(ds);
            }
            catch (Exception ex)
            {
                throw ex;
            }
            finally
            {
                con.Close();
            }

            return ds;

Answer 1

Here are some immediate improvements

Use using statement rather than try/finally for the connection management

Use throw and not throw ex to re-throw the exception, better yet you can just remove the catch and re-throw

There is no need to call Parameters.Clear on the command that you just instantiated.

And finally, if you are going to do a lot of DB work, I would suggest you look at using a lightweight ORM.