Question

Can someone please provide a way to handle the Fatal error: Call to a member function prepare() on a non-object.

Here is my Scenario:

I have a Singleton Database Class which stores my database details and creates an instance of a PDO object when requested.

I then have the following two classes:

Base class:

namespace lib\translator;
use lib\database as db;

class EntityTranslator {
    protected $dbConn;

    public function __construct() {
        try {
            $this->dbConn = db\Database::getInstance();
        }
        catch(\PDOException $e) {
            // do some error logging here
        }
    }
}

Sub class:

namespace lib\translator;
use lib\entity as entity;

class RequestTranslator extends EntityTranslator {

    public function __construct() {
        parent::__construct();
    }

    public function createRequest() {
        $request = new entity\Request();
        try {
            $stmt = $this->dbConn->prepare("CALL createRequest()");
            $stmt->execute();

            $rowCount = $stmt->rowCount();
            if ($rowCount == 1) {
                $row = $stmt->fetch(\PDO::FETCH_ASSOC);

        // do stuff with the data here
            }
            return $request;
        }
        catch (\PDOException $pdoe) {
        // do error logging here
        }
    }
}

Now, I am not wondering why the error occurs. I am trying to handle the very rare case when my database connection is not available and the PDO object instantiation (done via the call to db\Database::getInstance()) throws an exception, resulting in the variable $dbConn remaining null.

I realise, it would be possible to test $dbConn for null before using it each time. But As I stated, this should be an exceptionally rare situation and may in fact never occur, so I don’t think that checking for null each time is a smart performance choice.

I would like to be able to add on another catch(\Exception $ex){} block to handle what is essentially a NullPointerException (as seen in Java) but PHP does not provide for such an exception. Rather they issue the Fatal error: Call to a member function prepare() on a non-object.

So what I am looking for, is a way to handle this error, for this situation, without checking for null each time.

Maybe I have missed the basic concept of error handling in PHP, but I have not been able to find a definitive resource on this topic.

Any suggestions?

Answer 1

Why is your application allowed to call RequestTranslator::createRequest() anyway, when, at the time of instantiating RequestTranslator, you already know whether or not the database connection has instantiated properly?

Shouldn’t your application logic be something like the following:

try
{
    /*
     * the following line should throw
     * SomeMeaningfulException when it 
     * is unable to connect to the database
     */
    $rt = new lib\translator\RequestTranslator();

    /*
     * this line should not be reached
     * if the above throws SomeMeaningfulException
     */
    $rt->createRequest();
}
catch( SomeMeaningfulException $e )
{
    /* $rt database connection has not instantiated properly */
}

In other words, if you ask me, the constructor of RequestTranslator should already throw SomeMeaningfulException if it is unable to instantiate the database connection when the object’s methods are that dependant on functioning properly:

class EntityTranslator {
    protected $dbConn;

    public function __construct() {
        try {
            $this->dbConn = db\Database::getInstance();
        }
        catch(\PDOException $e) {
            // do some error logging here
            throw new SomeMeaningfulException( 'some meaningful message' );
        }
    }
}

If this is somehow not preferred, then I don’t see why checking for null is that much of an issue. I agree with others, that the performance penalty is probably neglectable.