Question

Can someone please tell me if this method of doing foreach has drawbacks?

class someclass {
  function foo() {
    foreach ($my_array as $this->key => $this->value) {
      $this->bar();
      $this->baz();
    }
  }
  function bar(){
    //do something with $this->key or $this->value
  }
  function baz(){
    //do something with $this->key or $this->value
  }
}

Answer 1

It’s pretty inefficient as you are essentially setting the key to an associative array on each loop. I would keep them local and then assign them when the loop is done if you need to store them. Also, pass the values to the methods when you call them.

class SomeClass {
    function foo($myArray) {
       foreach ($myArray as $key => $value){
           $this->bar($key);
           $this->baz($value);
        }
        $this->key = $key;
        $this->value = $value;
     }
    function bar($key){
     //do something with $this->key or $this->value
    }
    function baz($value){
     //do something with $this->key or $this->value
    }
 }