Question

Can someone tell me what is wrong with my code?

        $c =  '<div class="desc">';
    if( $_POST['login_post'] == '1') { 
    $username = $_POST['user_login'];
    $password = $_POST['password'];
        $message = log_in_user($username, $password);
    }
    display_message($message); 
    $c .= '<form name="loginform" id="loginform" method="post" action="">
                            <label>Username:</label>
                            <div><input type="text" name="user_login" id="user_username"  value="" size="20"  maxlength="40" tabindex="10" /></div>
                            </div>
                            <div class="group">
                            <label>Password:</label>
                            <div><input type="password" name="password" id="user_password"  value="" size="20"  maxlength="40" tabindex="20" /></div>
                            </div>
                             <input type="hidden" name="login_post" value="1"/>

                            <div class="group">
                            <label></label>
                            <div><input type="submit" name="submit" id="submit" class="bluebutton" value="Log In Now" /><span class="forgotlink"><a href="/forgot-password/">Forgot your password?</a></span></div>
                            </div> 
                </form>

                    </div>';
    $c = str_replace('%value%',5,$c);
    return $c;

That display_message($message); function is supposed to display the message inside the desc div. Instead, it is displaying above (outside) the desc div.

Am I concatenating PHP code incorrectly? If yes, can some one correct me? Thanks!

Update:

Here is my display_message function:

function display_message( $message = false ) {
    if( is_wp_error( $message ) ) {
        echo '<div class="errorMessage"><p>' . $message->get_error_message() . '</p></div>';    
    }
    elseif ($message != '') {
        echo '<div class="successMessage"><p>' . $message . '</p></div>';   
    }
}

Answer 1

display_message() will print out the message instead of concatenating it. Try changing display_message($message); to $c .= htmlspecialchars($message); and it should end up inside the div as it is supposed to.

Edit: Since display_message does more than just display the message, it needs to be rewritten slightly;

function format_message( $message = false ) {
    if( is_wp_error( $message ) ) {
        return '<div class="errorMessage"><p>' . $message->get_error_message() . '</p></div>';    
    }
    elseif ($message != '') {
        return '<div class="successMessage"><p>' . $message . '</p></div>';   
    }
}

and the concatenation should instead be;

$c .= format_message($message);