Question

Can you help me correct the code snippet.

I want to list the server which is type eq xyz but not with namedservers.

our %SERVERS = (
  "rajesh1" => {type => 'xyz', sha => 'ram'},
  "rajesh2" => {type => 'xyz', sha => 'sita'},
  "rajesh3" => {type => 'xyz', named => ["raa"]},
  "rajesh4" => {type => 'xxx', named => ["rajjaj"]},
);

while ( my $mServer = each(%SERVERS) ) 
{ 
  if ("$SERVERS{$mServer}{type}" eq "xyz" && !"$SERVERS{$mServer}{named}" ) 
  {
    print "Name of the server is $mServer\n";        
  }
}

Expected result:

rajesh1
rajesh2

Answer 1

1. You’re missing a semicolon after the definition of %SERVERS.
2. You start calling it $mServer, then later say $gServer. Pick one!
3. Get rid of the quotes around $SERVERS{$mServer}{type} and $SERVERS{$mServer}{named} (once you’ve changed gServer to mServer—you don’t need them.
4. You expect to see “rajesh1 rajesh2”, but none of them have type "prod". How is that possible? Assuming you change their type to "prod" …
5. You expect to see “rajesh1 rajesh2”, but you print "Name of the server is $mServer\n" (once you change gServer to mServer). Changing that to just "$mServer\n", and …
6. … it should work.

Hence:

our %SERVERS = (
    "rajesh1" =>  {type => 'prod', sha => 'ram'},
    "rajesh2" =>  {type => 'prod', sha => 'sita'},
    "rajesh3" =>  {type => 'xyz',  named => ["raa"]},
    "rajesh4" =>  {type => 'xxx',  named => ["rajjaj"]},
);

while (my $mServer = each %SERVERS) { 
    if ($SERVERS{$mServer}{type} eq "prod" && !$SERVERS{$mServer}{named}) {
        print "$mServer\n";
    }
}

Then:

$ perl test.pl 
rajesh1
rajesh2
$