Question

Can you suggest a nicer way of inserting a value before another value in an std::vector:

template<class T>
void insert(std::vector<T>& container, const T& valueToInsertBefore, const T& valueToInsert)
{
    std::vector<T>::iterator i = container.begin();
    std::vector<T>::iterator end = container.end();
    for(;i!=end;++i)
    {
        if(*i==valueToInsertBefore)
        {
            i = container.insert(i, valueToInsert); 
            i++;                                
            end = container.end();                  
        }
    }

}

UPDATE:

Should insert for each instance of valueToInsertBefore found in the std::vector.

Answer 1

Use std::find() to locate the value instead of the explicit loop:

std::vector<T>::iterator i = v.begin();
while (v.end() != (i = std::find(i, v.end(), valueToInsertBefore)))
{
    // insert() returns an iterator to the inserted element.
    // The '+ 2' moves past it and the searched for element.
    //
    i = v.insert(i, valueToInsert) + 2;
}