Question

Checkout my code I have been doing some work on an sms application and I am trying now to match the address that has came with the sms with the number that has been stored in the contacts…

So far I was unable to match the contact and display the name of the sender because on emulator contains only two contacts… It matches the first one and displays its name while on phone it doesnot finds a single contact…

public List<String> getSMS() {

        List<String> sms = new ArrayList<String>();
        Uri uriSMSURI = Uri.parse("content://sms/inbox");
        Cursor cur = getContentResolver().query(uriSMSURI, null, null, null,
                null);

        ContentResolver cr = getContentResolver();
        Cursor contactsCur = cr.query(ContactsContract.Contacts.CONTENT_URI,
                null, null, null, null);
        Cursor phoneCur = cr.query(
                ContactsContract.CommonDataKinds.Phone.CONTENT_URI, null,
                "DISPLAY_NAME = '" + name + "'", null, null);

        Log.v(LOG_TAG, "going in loop");
        if (contactsCur.getCount() > 0) {
            Log.v(LOG_TAG, "inside loop");
            while (contactsCur.moveToNext()) {
                Log.v(LOG_TAG, "cursor moving to next");
                id = contactsCur.getString(contactsCur
                        .getColumnIndex(ContactsContract.Contacts._ID));
                Log.i(LOG_TAG,"this is id: " + id);

                name = contactsCur
                        .getString(contactsCur
                                .getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
                Cursor phones = cr.query(Phone.CONTENT_URI, null,
                        Phone.CONTACT_ID + " = " + id, null, null);
                Log.i(LOG_TAG, "This is name "+name);
                while (phones.moveToNext()) 
                {
                     number = phones.getString(phones
                            .getColumnIndex(Phone.NUMBER));
                     String aNumber=number.replaceAll("-", "");
                     Log.i(LOG_TAG,"this is number :"+aNumber);

                    Log.v(LOG_TAG, "getting address and message");

                    while (cur.moveToNext()) {
                        String address = cur.getString(cur
                                .getColumnIndex("address"));
                        if(address.equals(aNumber))
                            address=name;
                        String body = cur.getString(cur
                                .getColumnIndexOrThrow("body"));

                        sms.add("Number: " + address+ " .Message: " + body);
                    }
                    Log.v(LOG_TAG, "closing phone cursor");
                    phoneCur.close();
                }

            }
        }

        return sms;

    }

Answer 1

I didn’t completely understood what you coded here.But I got your requirement.So my suggestion is-try this way(I haven’t tried it because of the lack of time for now,but logically it should work):

public List<String> getSMS() {

        List<String> sms = new ArrayList<String>();
        //fetch all inbox sms
        Cursor inboxCursor = getContentResolver().query(Uri.parse("content://sms/inbox"), null, null, null,null);

        if(inboxCursor.getCount()>0)
        {
            inboxCursor.moveToFirst();
            for(int i=0;i<inboxCursor.getCount();i++)
            {
                //get phone-number of sms
                String address=inboxCursor.getString(inboxCursor.getColumnIndex("address"));

                //fetch contacts with same phone-number
                Cursor contactCursor=getContentResolver().query(ContactsContract.CommonDataKinds.Phone.CONTENT_URI,null,ContactsContract.CommonDataKinds.Phone.NUMBER+"='"+address+"'",null,null);

                if(contactCursor.getCount()>0)
                {
                    contactCursor.moveToFirst();

                    // fetch the name associated with that number in contacts saved
                    String name=contactCursor.getString(contactCursor.getColumnIndex(ContactsContract.CommonDataKinds.Phone.DISPLAY_NAME));
                    //add number,name,message to list   
                    sms.add("Number: " + address+ " .Name: "+ name +".Message: " + body);
                }
                else 
                {  
                    // for unknown contact
                    // add number,name,message to list                     
                    sms.add("Number: " + address+ " .Name: Unknown .Message: " + body);
                }
                inboxCursor.moveToNext();
            }
        }
        return sms;
}

EDIT :

To group all sms from each contact:

    List<String> groupSms=new List<String>(); 
    // retrieve all contacts
    Cursor contacts=getContentResolver().query(ContactsContract.CommonDataKinds.Phone.CONTENT_URI,
                    null,null,null,null);     
    if(contacts.getCount()>0)
    {
        contacts.moveToFirst();
        for(int i=0;i<contacts.getCount();i++)
        {    
             // get phone number       
             String phone_number=contacts.getString(contacts.getColumnIndex(ContactsContract.CommonDataKinds.Phone.NUMBER)) ;
             // retrieve sms of phone_number from inbox
             Cursor sms=getContentResolver().query(Uri.parse("content://sms/inbox"), null, "address='"+phone_number+"'", null,null);
             if(sms.getCount()>0)
             {
                  sms.moveToFirst();
                  for(int j=0;j<sms.getCount();j++)
                  {
                      // get sms body
                      String text=sms.getString(sms.getColumnIndex("body"));    
                      // add "phone_number" and "text" to a list
                      groupSms.add(phone_number+":"+text);
                      // move to next sms from phone_number
                      sms.moveToNext();
                  }
             }
             //move to next contact
             contacts.moveToNext();
        }
    }