Question

    clone.find('[id]').each(function() {
        id = $(this).attr('id');
        ind = id.search(/\d+$/);
        $(this).attr('id', id.substr(0,ind)+id_counter);
    });
    clone.find('[for]').each(function() {
        id = $(this).attr('for');
        ind = id.search(/\d+$/);
        $(this).attr('for', id.substr(0,ind)+id_counter);
    });

I know I can find elements that have either the id attribute or the for attribute, but then how do I know which one I need to set?

Answer 1

If all you’re trying to do is reduce code, you could…

 function doTheseThings(element) {
    clone.find(element).each(function() {
       var id = $(this).attr('id');
       var ind = id.search(/\d+$/);
       $(this).attr('id', id.substr(0,ind)+id_counter);
    });
 }

 doTheseThings('[id]');
 doTheseThings('[for]');

EVEN BETTER:

I decided to meld my first answer with some of @SHiNKiROU’s ideas and add some more Jquery-ish syntax:

var items = ['[id]', '[for]'];
$.each(items, function (index, element) {
    clone.find(element).each(function() {
       var id = $(this).attr('id');
       var ind = id.search(/\d+$/);
       $(this).attr('id', id.substr(0,ind)+id_counter);
    });
});