Question

Consider this piece of code:

class A {
  void methodX() {
  // snip (1 liner function)
  }
}

class B {
  void methodX() {
   // same -code
  }
}
 

Now other way i can go is, I have a class(AppManager) most of whose members are static, (from legacy code, don’t suggest me singleton ;))

class AppManager {
  public:
  static void methodX(){
   // same-code
  }
}

Which one should be preferred?
As both are inlined, there shouldn’t be a runtime difference, right?
Which form is more cleaner?

Answer 1

Now first of all, this is a concern so minuscule that you would never have to worry about it unless the functions are called thousands of times per frame (and you’re doing something where “frames” matter).

Second, IF they are inlined, the code will be (hopefully) optimized so much that there is no sign whatsoever of the function being non-static. It would be identical.

Even if they were not inlined, the difference would be minor. The ABI would put the “this” pointer into a register (or the stack), which it wouldn’t do in a static function, but again, the net result would be almost not measurable.

Bottom line – write your code in the cleanest possible way. Performance is not a concern at this point.