Question

Could you please tell me what is the error here? it tells me that “gender” in toast make must be set to final but when I do, the if statements complain that it should not be final

@Override
protected void onCreate(Bundle savedInstanceState) {

    String gender = null;

    Toast.makeText(this, R.string.ok, Toast.LENGTH_LONG).show();
super.onCreate(savedInstanceState);
setContentView(R.layout.createprofile);



    RadioButton rb_male = (RadioButton) findViewById(R.id.maleradiobutton);
String   male=rb_male.getText().toString();

    RadioButton rb_female = (RadioButton) findViewById(R.id.femaleradiobutton);
    String female=rb_male.getText().toString();

    if(rb_male.isChecked()) { gender = "male";}
    if(rb_female.isChecked()){ gender = "female";}

    Button checkgender = (Button) findViewById(R.id.gendercheck);
    checkgender.setOnClickListener(new View.OnClickListener() {

        public void onClick(View v) {

            Toast.makeText(ProfileActivity.this, gender.toString(), Toast.LENGTH_LONG);
        }
    });




}




}

Answer 1

You have too many errors in there to really address completely. They include:

1. You grab text from the button into variables, then you write out literal strings “male” and “female” anyway.
2. You were grabbing text from the male button twice, and never the female button.
3. Declare your variables in the class, not in the onCreate method, and they will behave much better with no problems about being final and so on.
4. Your if statements checking the male and female buttons must be inside the method onClick(v). If they are outside, then a click does not cause them to be reevaluated and no amount of changing your buttons will change the result you get.
5. gender is already a String, gender.toString() does nothing to change that.
6. RadioButton don’t really do what you want, you probably want ToggleButton.
7. You probably want to put some logic in so only one of the buttons male or female can be checked at a time. They would each need a OnClickListener to do this.

Having said all that, here is the code with a lot of those changes made and probably some other stuff cleaned up a bit.

Good luck!

public class AndroidTest extends Activity {

   String gender = null;
   RadioButton rb_male;
   RadioButton rb_female;
   Button checkgender;

   @Override
   protected void onCreate(Bundle savedInstanceState) {

       Toast.makeText(this, "OK", Toast.LENGTH_LONG).show();
       super.onCreate(savedInstanceState);
       setContentView(R.layout.main);

       rb_male = (RadioButton) findViewById(R.id.maleradiobutton);
       rb_female = (RadioButton) findViewById(R.id.femaleradiobutton);

       checkgender = (Button) findViewById(R.id.gendercheck);
       checkgender.setOnClickListener(new View.OnClickListener() {

           public void onClick(View v) {
               if (rb_male.isChecked()) {
                   gender = "male";
               }
               if (rb_female.isChecked()) {
                   gender = "female";
               }
               Toast.makeText(AndroidTest.this, (CharSequence) gender, Toast.LENGTH_LONG).show();
           }
       });
   }

}