Question

Currently I have The following code:

void Page_Load(object sender, System.EventArgs e)
 {       
       string connectionString = "server=abc;database=abc;uid=abc;pwd=1234";
       SqlConnection mySqlConnection = new SqlConnection(connectionString);
       string procedureString = "Callin_Insert";
       SqlCommand mySqlCommand = mySqlConnection.CreateCommand();
       mySqlCommand.CommandText = procedureString;
       mySqlCommand.CommandType = CommandType.StoredProcedure;
       mySqlCommand.Parameters.Add("@LVDate", SqlDbType.DateTime).Value = DateTime.Now;
       mySqlCommand.Parameters.Add("@LVTime", SqlDbType.DateTime).Value = DateTime.Now;
       mySqlCommand.Parameters.Add("@CuID", SqlDbType.Int).Value = CustID;
       mySqlCommand.Parameters.Add("@Type", SqlDbType.Int).Value = Keypress;
       mySqlConnection.Open();
       mySqlCommand.ExecuteNonQuery();
       SqlDataAdapter mySqlDataAdapter = new SqlDataAdapter();
       mySqlDataAdapter.SelectCommand = mySqlCommand;
       mySqlConnection.Close();
}

Basically, I am opening a connection to the Database during the page_load. I am also closing that connection in page_load. Part of my problem is that the CustID & Keypress are not getting passed, because they occur later in the page life cycle. What is the best way to open the connection, get the 2 variables (when I they are entered by the user), pass them to the database, and close the connection.

Somethings I have tried is running it _OnLoad. But this didn’t work either.

Any thoughts or suggestion, are greatly appreciated.

Answer 1

First of SqlConnection is of IDisposible interface means it is much safer to wrap your code with using statement like this.

string connectionString = "server=abc;database=abc;uid=abc;pwd=1234";
using (SqlConnection mySqlConnection = new SqlConnection(connectionString))
{
    string procedureString = "Callin_Insert";
    SqlCommand mySqlCommand = new SqlCommand(procedureString, mySqlConnection);
    mySqlCommand.CommandType = CommandType.StoredProcedure;

    mySqlCommand.Parameters.Add("@LVDate", SqlDbType.DateTime).Value = DateTime.Now;
    mySqlCommand.Parameters.Add("@LVTime", SqlDbType.DateTime).Value = DateTime.Now;
    mySqlCommand.Parameters.Add("@CuID", SqlDbType.Int).Value = CustID;
    mySqlCommand.Parameters.Add("@Type", SqlDbType.Int).Value = Keypress;

    mySqlConnection.Open();
    mySqlCommand.ExecuteNonQuery();

    //i have no idea what does this mean, data adapter is for filling Datasets and DataTables
    SqlDataAdapter mySqlDataAdapter = new SqlDataAdapter();
    mySqlDataAdapter.SelectCommand = mySqlCommand;
}

Second of all i offer you to use SqlDataSourceObject control which will make much easier to work with cases like yours.

It will know how to deal with Page.IsPostBack that you haven’t implemented but should, paging and other stuff you need.